On Friday, October 18, 2013 1:53:46 PM UTC+2, Goktug Gokdogan wrote: > > > > > On Fri, Oct 18, 2013 at 12:10 PM, Thomas Broyer > <t.br...@gmail.com<javascript:> > > wrote: > >> >> >> On Friday, October 18, 2013 7:21:48 AM UTC+2, Colin Alworth wrote: >>> >>> Just wandered by >>> https://gwt-review.**googlesource.com/#/c/1040/<https://gwt-review.googlesource.com/#/c/1040/>and >>> noticed that with this change, any downstream generator/linker using >>> the static helper methods in Name will no longer build across 2.5.1 to >>> 2.6.0. With the other discussions going on about JRE and browser support, >>> perhaps we could discuss something policy-like around 'internal' code like >>> this? >>> >>> If the policy that internal public methods are not actually for public >>> consumption, or subject to breakage across minor releases, we should note >>> that somewhere to keep people away. My inclination is that we want to >>> encourage downstream code to use utility methods like this rather than >>> copying them into their own projects. >>> >> >> This is what the c.g.g.util is for AFAICT, with c.g.g.util.tools.shared >> being for things usable "on server-side" (included in gwt-servlet); and as >> a rule of thumb any class not listed in the javadocs we generate should be >> considered "private". >> AFAICT, the rule has always been to first make those utilities private as >> "incubators" and then move them to a "public" place when they're ready for >> prime-time. >> >> Re. this specific change, we could do the move in 2 steps though: make >> the c.g.g.dev.util classes simply call to the new c.g.g.tools.util.shared >> ones, and deprecate them; and remove them in a later release. >> > > Actually, I'm not sure if the compiler guys were treating c.g.g.dev.util > as public. >
I do believe they treated it as private (see the javadoc for c.g.g.dev.util.Util) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
