Seems to look good. Seems pretty similar to the single @Js annotation version but reads better because of separate @JsMethod/@JsProperty/@JsConstrutor annotations and gives the possibility to add specific attributes to just one of them if ever needed.
Two short questions: - JsConstrutor does not have a name attribute so maybe its worth documenting that you can not use JavaScript reserved words as (yes, ugly lower case) class names when @JsConstructor(export = true) is used? - Currently name and export attributes are repeated through @JsType/Constructor/Method/Property. Is there any reason why @JsNamespace stands alone? For consistency I would probably convert @JsNamespace into an attribute as well, especially if @JsNamespace can be used with all four annotations. -- J. -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/bf832bd5-ae11-45eb-9421-bc73d5aff1a2%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
