FYI, After the introduction of native JsTypes[1], the value of an explicit "export" attribute is minimal to none.
We don't generate any code for native types anyway which is only place that you might consider having a JsType without an export so attribute doesn't add any value there. If you extend a native JsType, you probably want the overridden methods exported anyway so we are good. I will remove them from my latest patch and submit it so that you can start using new annotations and give us feedback. Without the "export", everything is much simpler. I will share the updated JsInterop doc with the latest spec this week. Cheers. [1] https://groups.google.com/d/msg/google-web-toolkit-contributors/E48-XJGpz7w/kxhfiK3jAgAJ On Fri, May 22, 2015 at 8:38 PM, Goktug Gokdogan <[email protected]> wrote: > > > On Fri, May 22, 2015 at 12:22 PM, Jens <[email protected]> wrote: > >> Seems to look good. Seems pretty similar to the single @Js annotation >> version but reads better because of separate >> @JsMethod/@JsProperty/@JsConstrutor annotations and gives the possibility >> to add specific attributes to just one of them if ever needed. >> >> Two short questions: >> >> - JsConstrutor does not have a name attribute so maybe its worth >> documenting that you can not use JavaScript reserved words as (yes, ugly >> lower case) class names when @JsConstructor(export = true) is used? >> >> > We will have a check for this but I agree it is a good idea to document > this in javadoc. > > >> - Currently name and export attributes are repeated through >> @JsType/Constructor/Method/Property. Is there any reason why @JsNamespace >> stands alone? For consistency I would probably convert @JsNamespace into an >> attribute as well, especially if @JsNamespace can be used with all four >> annotations. >> >> >> > Export and name attributes are always valid to set while namespace can be > set on only static members. Also we need it so that we could set the > namespace on package-info file. > > An alternative solution would be introducing JsPackage annotation to use > with package-info file and introduce namespace attribute where applicable. > That would be more consistent with the rest. > > >> -- J. >> >> -- >> You received this message because you are subscribed to the Google Groups >> "GWT Contributors" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/google-web-toolkit-contributors/bf832bd5-ae11-45eb-9421-bc73d5aff1a2%40googlegroups.com >> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/bf832bd5-ae11-45eb-9421-bc73d5aff1a2%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA1Cywfrn3jH8jYPHsG0%2BiJsMg1svq%3DW%2B%2BAoBLGpgjpKAA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
