On Friday, October 6, 2017 at 7:55:15 PM UTC+2, Colin Alworth wrote: > > Okay, I'm about 80% sure that I understand and can remedy the problem > within HtmlUnit itself. Will update once I finish syncing the apparently > canonical SVN repo to git, so I can go over the history more carefully and > ensure that this break isn't deliberate. > > A question for my fellow GWT maintainers: should I patch the version of > HtmlUnit that we presently use, so that we avoid breaking downstream > expectations (plugins that specify specific browsers, use if IE8 or IE11 as > a user agent to run the tests as)? Or should I see about getting this patch > into the next version of HtmlUnit, and we wait on their release cycle, and > leave this broken until then? >
I'd say it depends on their release cycle; but we could bundle a patched HtmlUnit into gwt-user (like we bundle a patched JDT into gwt-dev) to get the fix early without waiting for the next HtmlUnit release (assuming the patch would get merged upstream!) If you (Daniel & Colin) think we should get the fix in 2.8.2, then let's do this (bundle a patched HtmlUnit into gwt-user). Note that we could possibly just bundle the patched class, and not the whole jar(s)! -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/a2fa6de1-b4fb-4221-b3b7-e882bbecdffc%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
