On Saturday, October 7, 2017 at 3:01:52 PM UTC+2, Colin Alworth wrote: > > Exactly - I wasn't planning on adding the javaToJs(), but was going to > unwrap the exception before calling onerror (or have ScriptException > implement Scriptable). Have a short test that demonstrates the issue > without gwt (but wow they have a lot of GWT in their source tree), and am > was waiting for my svn->git sync to finish to confirm what you did by hand. > Just in case we decide to rebase it along, or make other improvements down > the road... >
I wonder if we couldn't workaround the issue with a custom JavaScriptEngine's handleJavaScriptException? (override it with the same code except with the triggerOnError call "inlined" with the "fix") This possibly would allow us to have Daniel's change in 2.8.2, without the need to update or locally-patch HtmlUnit at all (and then wait for the fixed HtmlUnit before updating it, for 2.9, removing support for JDK 7 entirely) I'll dig this up while you work on a real fix ;-) -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/19c0880f-00b1-46b4-aaae-15b3fd79c978%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
