+1 to merge. On Thu, Jun 25, 2020, 4:26 PM Juan Pablo Gardella < [email protected]> wrote:
> +1 to merge them. It seems the simplest solution. > > On Thu, 25 Jun 2020 at 17:23, Colin Alworth <[email protected]> wrote: > >> One potential option could be moving the tests into gwt-safecss, and only >> release them together - the release process through sonatype will permit >> you to push more than one set of artifacts, test them in the staging repo, >> and then release to central together. That would imply using either local >> artifacts to build gwt-safecss (instead of pulling from central), or >> temporarily adding the staging repo to the pom. >> >> It does seem simpler to just merge to gwt-safehtml - especially since I >> doubt that gwt-safecss is often used by itself. >> >> On Thursday, June 25, 2020 at 3:19:05 PM UTC-5 juan_pablo_gardella wrote: >> >>> Not too much options I think, see >>> https://stackoverflow.com/questions/55429921/how-to-fix-cyclic-dependency-between-java-modules >>> >>> Maybe a new common shared module (maven artifact in this case) or merge >>> safehtml and safecss into a new one and let them deprecated. >>> >>> Juan >>> >>> On Thu, 25 Jun 2020 at 17:14, 'Frank Hossfeld' via GWT Contributors < >>> [email protected]> wrote: >>> >>>> To prepare GWT for j2cl we need to move the modules out of GWT, replace >>>> generators with ATP, etc. This is in progress and the first modules >>>> (SNAPSHOT) are released. >>>> >>>> Migrating gwt-safehtml and gwt-safecss runs into a problem, cause >>>> gwt-safehtml depends on gwt-safecss and gwt-safecss depends on >>>> gwt-safehtml. This is a serious issue, cause one can not be build and >>>> tested without the other. >>>> >>>> To solve this issue, we are looking for solutions. >>>> >>>> One solution might be to move the tests out of gwt-safehtml. But then >>>> gwt-safehtml needs to be build and deployed before the tests run and might >>>> be deployed with failing tests. That looks like a bad solution. At the >>>> moment the idea is to move the sources and tests from gwt-safecss into >>>> gwt-safehtml and delete gwt-safecss. This will remove the cycle dependency >>>> between these two modules, but doing so, the module will be the first >>>> module that contains two old modules in one new. >>>> >>>> Any other ideas how to solve this issue? >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "GWT Contributors" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web visit >>>> https://groups.google.com/d/msgid/google-web-toolkit-contributors/a8d6c785-c8d9-4eba-8cc2-0b42ecac1124o%40googlegroups.com >>>> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/a8d6c785-c8d9-4eba-8cc2-0b42ecac1124o%40googlegroups.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "GWT Contributors" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/google-web-toolkit-contributors/8b4addde-bf52-4a88-b38f-fd2c0493f9f9n%40googlegroups.com >> <https://groups.google.com/d/msgid/google-web-toolkit-contributors/8b4addde-bf52-4a88-b38f-fd2c0493f9f9n%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- > You received this message because you are subscribed to the Google Groups > "GWT Contributors" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/google-web-toolkit-contributors/CA%2BkiFscwn64KFDxxoqNx5hKRWCVQZ08HkS9GkbZvw6%3D%3D_5YcWA%40mail.gmail.com > <https://groups.google.com/d/msgid/google-web-toolkit-contributors/CA%2BkiFscwn64KFDxxoqNx5hKRWCVQZ08HkS9GkbZvw6%3D%3D_5YcWA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAKAo3tSKeM_bywaLaQPqujdYwSe-DfGy-47JPTJnB1q%2BQHcxrA%40mail.gmail.com.
