On Monday, June 29, 2020 at 8:43:25 AM UTC+2 [email protected] wrote:
> Thanks everybody for input. > > As @Colin already mentioned I was talking about option 4 of Thomas list. I > have moved gwt-safecss as separate modules into gwt-safehtml. (Need to add > a note at the existing GitHub repo of gwt-safecss that the modules have > moved after the PR is merged). I made a PR: > https://github.com/Vertispan/gwt-safehtml/pull/6. Everybody is welcome to > discuss the PR. > > There is one thing that needs to be discussed: > Atm the name of the module is the last part of the groupid. For example > gwt-editor: 'org.gwtproject.editor'. So, we have an easy rule how the > groupid and artifatid is created. > > Moving gwt-safecss into gwt-safehtml, we will have the first time two > modules in one repo. Both modules share the same parent Maven module. If > we do nothing, the rule mentioned above will work for gwt-safehtml but not > for gwt-safecss. gwt-safecss has the groupid 'org.gwtproject.safehtml' > cause of the parent pom. I changed that, so that the groupid of gwt-safecss > is 'org.gwtproject.safecss'. But doing this is very unusual for a Maven > multi module project. > Actually, not that much. Guice has com.google.inject and com.google.inject.extensions in the same reactor; Jetty has org.eclipse.jetty, org.eclipse.jetty.http2, org.eclipse.jetty.websocket, etc. Actually, even org.apache.maven:maven-parent <https://search.maven.org/artifact/org.apache.maven/maven-parent/34/pom> has submodules in different groupIds, including one that doesn't start with org.apache.maven (namely org.apache.apache.resources:apache-resources-bundles <https://search.maven.org/artifact/org.apache.apache.resources/apache-resource-bundles/30/pom> ) > Personally I would go with 'org.gwtproject.gwt-safecss' as groupid. It > will make it much easier for gwt users to work with the module. > > What do you think? > Do you really mean org.gwtproject.gwt-safecss as groupId‽ I.e. org.gwtproject.gwt-safecss:gwt-safecss coordinates‽ I'd be OK with org.gwtproject:gwt-safecss, but how about org.gwtproject.safetypes grouping both gwt-safehtml and gwt-safecss? (and possibly gwt-safeuri, gwt-safehtml-templates gwt-safehtml-templates-processor if we split further) Or org.gwtproject.safe-html-types, inspired by https://github.com/google/safe-html-types? Or just keep using the "root" package name as the groupId: org.gwtproject.safehtml:gwt-safehtml (and then annotation processor, etc.) and org.gwtproject.safecss:gwt-safecss (and later possibly org.gwtproject.safeuri:gwt-safeuri) -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/35f86f90-d56f-42ce-b3b8-8f76085026d1n%40googlegroups.com.
