On Tue, Feb 27, 2018 at 12:51:34AM +0300, Alexey Kryukov wrote: > Hi Marcus, > > please find attached my patch for EOS M2 support. The changes (except > obvious ones) are as follows: > > -- is_canon_eos_m() now returns an EOS M version (not just 1 or 0). > That's because M2 has turned out to have a "normal" EOS capture/AF > method, so need to treat it separately from PowerShot-based M cameras at > this context; > > -- copypasted the code for EOS M non-focus to camera_trigger_capture() > (not affected by the previous patch). However also had to modify a bit > this function to skip previous events (as in camera_capture()), as > otherwise a wrong event is checked when looking for a button state; > > -- modified ptp_unpack_EOS_FocusInfoEx() as proposed previously.
I split parts out and merged the 2nd and 3rd prt, changed the 3rd a bit. I don't like the hardcoding in part 1, there must be some better way. Can you send debug logfile output of an EOS M2 capture with your patch applied? (You can strip out the image data.) Ciao, Marcus ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Gphoto-devel mailing list Gphoto-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/gphoto-devel
