http://bugs.gpodder.org/show_bug.cgi?id=60


Janne Makela <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #212 is|0                           |1
           obsolete|                            |




--- Comment #20 from Janne Makela <[email protected]>  2009-03-03 19:53:09 ---
Created an attachment (id=259)
 --> (http://bugs.gpodder.org/attachment.cgi?id=259)
Patch updated to work with the latest changes in the repository

There have been so many code changes in the repository that this patch hasn't
been working for over a month. So I updated it, although gui.py part is not
particularly polished at this point (it's actually a bit worse than the
previous one).

It would probably be best to go through the gui.py change by change and see if
it could be made better. I stayed away from some changes simply because I
thought that some function name changes and refactoring should be done only
after seeing that this thing actually works for everyone.

I don't see much risk in applying the patch for other files, so it's mostly
gui.py that requires special attention. For example, pay attention to the
updateTreeView function. Unwatched tree model fetching is placed inside the
thread code, but it might not be the best place after all. Also, Maemo UI could
become be badly broken, since I don't have that device to test on.

Well, this works for me right now. Feedback is appreciated:)

-- 
Configure bugmail: http://bugs.gpodder.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
gPodder-Bugs mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/gpodder-bugs

Reply via email to