http://bugs.gpodder.org/show_bug.cgi?id=408


Thomas Perl <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
         AssignedTo|[email protected]             |[email protected]
     Ever Confirmed|0                           |1




--- Comment #2 from Thomas Perl <[email protected]>  2009-04-11 09:09:03 ---
Thanks for your patch. Before I am going to apply it, there are some comments
and questions. In file_age_nice, you have:

+    if not os.access(filename, os.R_OK):
+        return (None, None)

Is it really necessary to have read permissions on that file in order to be
able to retrieve the modification date and time?

Also. you don't seem to be using file_age_to_string. Maybe you can leave the
"modified" string as it is (using util.file_age_to_string and just try to get
the modified time as a number; returning -1 if the modified time cannot be
determined.

-- 
Configure bugmail: http://bugs.gpodder.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
gPodder-Bugs mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/gpodder-bugs

Reply via email to