http://bugs.gpodder.org/show_bug.cgi?id=408
Torbjörn Wassberg <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #282 is|0 |1 obsolete| | --- Comment #3 from Torbjörn Wassberg <[email protected]> 2009-04-18 09:27:51 --- Created an attachment (id=286) --> (http://bugs.gpodder.org/attachment.cgi?id=286) A bit more cleanup (In reply to comment #2) > Thanks for your patch. Before I am going to apply it, there are some comments > and questions. In file_age_nice, you have: > > + if not os.access(filename, os.R_OK): > + return (None, None) > > Is it really necessary to have read permissions on that file in order to be > able to retrieve the modification date and time? No, and any problems will be caught by the exception anyway. > Also. you don't seem to be using file_age_to_string. Maybe you can leave the > "modified" string as it is (using util.file_age_to_string and just try to get > the modified time as a number; returning -1 if the modified time cannot be > determined. The reason was to change to util.format_date instead. As I think it gives a better overview (and MTPDevice is already using it for this purpose). -- Configure bugmail: http://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
