https://bugs.gpodder.org/show_bug.cgi?id=519
--- Comment #3 from Thomas Perl <[email protected]> 2009-07-31 12:29:51 GMT --- (In reply to comment #2) > Here is a patch that mostly fixes the problem. But I still get a few cases > where setting the channel title causes the directory to be named 'Something > (2)' etc. Thanks for the patch. Will merge in my next patch-applying run :) > I don't quite understand why we have channels stored in the database after > they > are removed from the feed list, or is it just that I have messed up my > database > somehow? This is for the cases where the user opts for leaving the files untouched when deleting a podcast channel. In general, the podcast is always kept (even if the files are deleted) because of the episode status (i.e. already downloaded) that should be kept even if the channel is deleted. That said, I think it's reasonable to "steal" the folder name from a channel that a) is deleted (deleted=1) AND b) does not have a corresponding download folder In this case, you can set the download folder name of the deleted channel to NULL (in this case it will be generated the next time it is used - which could be never in case the channel is never re-added). After setting the name of the deleted channel to NULL, you can re-use its folder name. Hmm.. maybe we should do this (setting the foldername to NULL for channels that fulfull the two preconditions a) and b) above not only when requesting a foldername but also when deleting a channel (only if the download files are deleted, too). Do you think you could come up with a patch? That'd be really helpful :) -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
