https://bugs.gpodder.org/show_bug.cgi?id=519
--- Comment #5 from Thomas Perl <[email protected]> 2009-07-31 19:13:04 GMT --- (In reply to comment #4) > Will have a go at it over the weekend ;-) Great, thanks :) > Just to be clear, what we do is: > > 1) When deleting a feed, if also deleting episodes, set foldername to NULL > (are > we sure having a foldername=NULL in the db will not break anything else?) Yep, foldername=NULL is supported because we had to support migrating from previous versions of gPodder. The relevant function here is get_save_dir() in libpodcasts.py, which determines the download folder for the channel. In the case where foldername is NULL, it determines a new folder name and commits to using that in the future by saving the value in the database. > 2) When requesting a foldername, if the requested name is used, but by a feed > that is deleted and the download folder does not exists set the foldername > for this feed to NULL, and allow the name to be used Exactly. The deleted feed doesn't "need" the foldername (except when the folder exists, in which case there is potentially the cover image and some downloaded files in there that we don't want to touch and also not re-use). Setting it to NULL from a non-NULL value is OK in this case, because from a user's perspective the folder name is unused. -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
