https://bugs.gpodder.org/show_bug.cgi?id=797
Thomas Perl <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED --- Comment #9 from Thomas Perl <[email protected]> 2010-02-05 20:30:34 GMT --- (In reply to comment #8) > Created an attachment (id=417) --> (https://bugs.gpodder.org/attachment.cgi?id=417) [details] > passing config option as attribute > > Stripping useless log missed while c/p Hmm. I don't really like that solution of renaming everything, there are many files that "depend" on show_message: $ git grep show_message | cut -d: -f1 | sort -u src/gpodder/gtkui/desktop/channel.py src/gpodder/gtkui/desktop/dependencymanager.py src/gpodder/gtkui/desktop/deviceplaylist.py src/gpodder/gtkui/desktop/preferences.py src/gpodder/gtkui/desktop/sync.py src/gpodder/gtkui/frmntl/episodeselector.py src/gpodder/gtkui/frmntl/episodes.py src/gpodder/gtkui/frmntl/podcastdirectory.py src/gpodder/gtkui/interface/addpodcast.py src/gpodder/gtkui/interface/common.py src/gpodder/gtkui/maemo/channel.py src/gpodder/gtkui/maemo/episodeselector.py src/gpodder/gtkui/maemo/podcastdirectory.py src/gpodder/gtkui/maemo/shownotes.py src/gpodder/gtkui/mygpodder.py src/gpodder/gui.py A solution would be to establish a parent-child relationship between all the different BuilderWidget objects and passing the calls to show_message, etc.. up to the root of this tree (that's the "gPodder" object) and from there carry out the action. This way, we still have to change all constructor calls to BuilderWidget-derived objects, but we don't have to change the show_message and notification calls while still only managing the notifications at one place. This might also come in handy in the future when we might want to log / post-process or collect notifications for any reason. I'll give this a shot in the upcoming days. -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
