https://bugs.gpodder.org/show_bug.cgi?id=1498
--- Comment #6 from Thomas Perl <[email protected]> 2012-01-22 10:09:09 GMT --- Here's the review for your "master-3.1" branch (couldn't find a better place): What does "gpodder.src_folder" do? Do we really need it? What does "gpodder.notify" do? Do we really need it? Get rid of trailing whitespace (visible in "git diff" in red). Don't use threading.Thread in Gtk UI code (can give problems). I haven't looked in detail into the new dialogs and the new extension module yet. We'll have to do a separate review of the notification module, but here are some starting points: * Get rid of "is_initted" -> just check it at the start of message() * init_notify only needs the "config" parameter, the rest (app name and icon) can be taken from the "gpodder" module or is constant ("gPodder") The EXTENSION_CLASS should probably be named gPodderExtension, singular (note the missing "s"). src/gpodder/util.py: * _MIME_TYPES can be generated from _MIME_TYPES_EXT (or vice versa), right? * Add ">>> " in front of the calls in extension_from_mimetype() to make them doctests ;) * Did you miss some extensions (.spx, .axa, .m4b, .axv) while refactoring? -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
