https://bugs.gpodder.org/show_bug.cgi?id=1498
--- Comment #7 from Bernd Schlapsi <[email protected]> 2012-01-22 16:53:59 GMT --- (In reply to comment #6) > What does "gpodder.src_folder" do? Do we really need it? Ok, I removed it now. this wasn't necessary > What does "gpodder.notify" do? Do we really need it? This stores the Notification class. I use it here: https://github.com/brot/gpodder/blob/master-3.1/src/gpodder/extensions.py#L100 > Get rid of trailing whitespace (visible in "git diff" in red). hopefully done > Don't use threading.Thread in Gtk UI code (can give problems). This is an open issue at the moment. This refers to the subject we talked on IRC (we should really abstract the creation of threads) > * Get rid of "is_initted" -> just check it at the start of message() done > * init_notify only needs the "config" parameter, the rest (app name and icon) > can be taken from the "gpodder" module or is constant ("gPodder") done > The EXTENSION_CLASS should probably be named gPodderExtension, singular (note > the missing "s"). done > src/gpodder/util.py: > * _MIME_TYPES can be generated from _MIME_TYPES_EXT (or vice versa), right? no, because they are not 1:1. the mime-type 'audio/ogg' could have more than one extensions (oga, ogg, spx) > * Add ">>> " in front of the calls in extension_from_mimetype() to make them > doctests ;) done > * Did you miss some extensions (.spx, .axa, .m4b, .axv) while refactoring? add the messing extensions -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
