https://bugs.gpodder.org/show_bug.cgi?id=1579
Thomas Perl <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|low |medium Status|UNCONFIRMED |CONFIRMED Target Milestone|--- |3.2 Summary|Proposed code for adding |iPod/MP3 player device |back device sync in v3.0 |synchronization for gPodder | |3 Ever Confirmed|0 |1 --- Comment #1 from Thomas Perl <[email protected]> 2012-03-15 08:35:59 GMT --- Thanks for the patch. Some feedback (assuming this code will be rewritten as extension): * See http://help.github.com/set-your-user-name-email-and-github-token/ on how to set your real name and e-mail address in Git (you can ignore the GitHub Token things on that page) - right now, the patch says "Joseph <joseph@uchikoma.(none)>" * Instead of menuDevice, we should have an "Extras" menu that will allow extensions to add menu items there. * For the preferences, we should probably make this via some extension mechanism, although I'm not sure how exactly * gPodderSyncProgress should go away -> We plan to use the "Downloads" tab in the main window as generic "progress" tab in future versions, so the sync progress should appear there instead of the modal dialog * gPodderSettings_LegacySupport in config.py is (as the name says) only for "legacy support". As the device sync stuff gets rewritten as extension, these settings should be placed as default config into the extension (which will then be attached to the main config automatically) * Stuff like scrobbler.log and rockbox cover art should be removed from the default extension. It could either be implemented as additional extension or be refactored extensively. It's rather irritating to configure for now * gPodderSyncUI and everything around that should be moved to the extension * libconverter should go and be replaced by something else (there are lots of converter extensions already available that convert files after download) * is_played in PodcastEpisode is deprecated for a reason. Please don't resurrect it. * With changes like the change to "sync_filename", don't comment out the old stuff - remove it (we have all the old stuff in the repository, anyway, so no need to clutter the codebase with dead, commented-out code) * sync_to_devices and device_name should be removed from the model - these things can and should be configured as configuration options in the extension (e.g. through a list of podcast feed URLs that should be synced) * As with the model, the database schema should also not be changed - "is_played" was changed to "is_new" (with the boolean meaning inverted) * Remove the services.dependency_manager stuff from sync.py - it has been removed and should not be resurrected again (use extension dependencies for that) * You call the non-existing function log() in util.py - use the "logger" object instead * What is the purpose of the "Reverted 'visible headers' change to episodeselector.ui" commit? The commit message doesn't tell me :/ Apart from that, the patch looks like a good starting point for getting device sync back into gPodder - thanks for that! :) -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
