https://bugs.gpodder.org/show_bug.cgi?id=1579
--- Comment #5 from Thomas Perl <[email protected]> 2012-06-13 17:35:13 BST --- (In reply to comment #4) > Created attachment 712 [details] > - Renamed the config section to 'device_sync' from sync > - Renamed the configuration items as suggested (including regrouping the > 'after_sync' section separately > - Removed the 'ACTION' items from DeviceTypeActionList > - Tried to remove as much trailing whitespace as possible > - Removed the backslashes as much as possible (still used once or twice) and > tried to adhere to the 80-char line limit as per PEP-8 > - Fixed the spacing issues with directory_is_writable > - removed pre_sync conversion code & libconverter > - Fixed error from call to logger > - Note that when the GTK Notification Extension is loaded, you'll get an error > message when you try to sync without a device configured. Thanks for the updated patch. As discussed, I'll postpone my review for the next update or when you want to try out Github, I'll add comments to the pull request there (please feel free to post the link to the pull request in this bug report once one is opened). -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
