On Friday 05 Mar 2010 15:45:56 Shao Miller wrote: > Good day to all, > > Last night I submitted a couple of patches for the scripting system. I > wanted to throw them out there so they could be used by anyone needing > them, but I'd enjoy a bit of discussion and value feedback regarding the > features they introduce. > > Some questions I have: > * Should 'exit' in a script > - exit just the currently executing script? > - exit all executing scripts? > - exit gPXE?
"Exit just the currently executing script" feels cleanest to me. > * Should the semantics of the 'loop' command be changed to > - No argument means do not loop? (Where user must specify a literal, > such as "1" to force an unconditional loop) Maybe "loopif" rather than "loop", to make it more intuitively obvious that the argument is required? > I believe that if and when the scripting system is revisited, 'exit' and > 'loop' should be trivial to port. My concern is that it's been quite > some time we've all been thinking about this revisit, but in the > meanwhile some users are missing commonly requested features. At a cost > of 69 bytes uncompressed (or less, if these patches can be easily > re-worked to cost less), are these two features worth incorporating at > this time? In the bazaar spirit, 69 bytes seems worth it to me. Michael _______________________________________________ gPXE-devel mailing list [email protected] http://etherboot.org/mailman/listinfo/gpxe-devel
