In staging, the top two commits at: http://git.etherboot.org/?p=gpxe-staging.git;a=shortlog;h=refs/heads/sha0-73_74-exit_loopif
Shao Miller wrote: > Michael Brown wrote: >> >> Looking at the patch itself... >> >> Could this be rearranged to avoid goto? We generally use goto only for >> structured error clean-up. >> >> Also, using -ENOTSUP as a magic value meaning "loop" seems kind of icky. >> There's a similarity between "exit" and "loopif" here; both commands >> need to >> set temporary state that affects the "move to next line of script" >> logic. >> Maybe have "loopif" set a flag as well; still fairly icky but at >> least it's >> icky in the same way that "exit" currently is. >> > > Or perhaps this patch, which costs 82 bytes uncompressed, and uses a > separate looping variable. > > - Shao Miller _______________________________________________ gPXE-devel mailing list [email protected] http://etherboot.org/mailman/listinfo/gpxe-devel
