Hi Laurent,
Just some minor stuff this time...
MarlinRenderingEngine.java:
line 378 - my eye just caught this. "between the stroker and Dasher"?
It looks like this is going between the stroking engine and the
Renderer, no?
MarlinUtils.java:
the getCallerInfo stuff may eventually need to be in a doPrivileged
context, but we don't need to deal with that now.
Renderer.java:
lines 46-50 - something looks off on the indentation there
line 53 - I believe that getUnsafe() would need a doPrivileged as well
lines 1385-1400 - lots of indentation issues
...jim
On 3/27/15 10:17 AM, Laurent Bourgès wrote:
Jim,
Here is a new webrev:
http://cr.openjdk.java.net/~lbourges/marlin/marlin.5/
Changes:
- Fixed all single line comments to use // (no javadoc) in all files
- removed Renderer.finalize ()
- renamed FastMath to FloatMath that use optimized ceil / floor methods
for float values derived from StrictMath methods
Joe, could you have a look to FloatMath ? I adapted the code based on
double values to float values + ceil returns directly an int.
It seems a bit faster in my benchmarks but not as much as the previous
trick.
Note: there is no more copyright issue.
Cheers,
Laurent
