(cc Laura) On Mon, Nov 3, 2008 at 1:15 PM, Paul Kelly <[EMAIL PROTECTED]> wrote: > On Mon, 3 Nov 2008, Hamish wrote: > >> MN: >>> >>> We can certainly freeze devel_grass6 and just tag RC1 >>> directly from that and test it rigorously. But are we >>> sure that nobody inserts new features? >> >> As a priority I think we can copy r.viewshed over intact, > > r.viewshed still needs updating to GRASS style and conventions, e.g. there > are at least quite a lot of printf() statements - from a quick glance a lot > of these seem to be in code used for debugging and benchmarking and there > are also comments such as "only used in standalone version". Code that is > not used should be removed I feel, but it could be a lot of work.
Possible it is a mixture of the standalone non-GRASS version and the GRASS version? There is yet a precision problem in r.viewshed, just run grass-addons/raster/r.viewshed/testscript.sh in any location to see the problem and differences to r.los. Markus _______________________________________________ grass-dev mailing list [email protected] http://lists.osgeo.org/mailman/listinfo/grass-dev
