On Sun, Jul 28, 2024 at 3:07 PM Sebastiaan Couwenberg via grass-dev <grass-dev@lists.osgeo.org> wrote: > > On 7/28/24 2:51 PM, Nicklas Larsson via grass-dev wrote: > >> On 28 Jul 2024, at 13:30, Sebastiaan Couwenberg via grass-dev > >> <grass-dev@lists.osgeo.org> wrote: > >> > >> On 7/28/24 11:54 AM, Markus Neteler via grass-dev wrote: > >>> I just discovered that the tarball no longer contains the version in > >>> the tarball "grass" subdir (expected "grass-8.4.0"): > >>> tar tvfz ~/grass-8.4.0.tar.gz | head > >>> drwxr-xr-x runner/docker 0 2024-07-27 15:34 grass/ > >>> [...] > >>> Why is that? Is it a feature? > >>> It breaks e.g. the (Fedora) RPM packaging procedure...
I need to add that I had tried to use (this time) the tarball from GitHub. > >> That tarball used for the Debian package from > >> https://grass.osgeo.org/grass84/source/ includes the version in the > >> toplevel directory: > >> > >> $ tar tavf ../grass-8.4.0.tar.gz | head -1 > >> drwxrwxr-x root/root 0 2024-07-27 13:27 grass-8.4.0/ > > > > The tarball from https://grass.osgeo.org/grass84/source/ is not the same as > > the one on Github, it also does not contain the "include/VERSION_GIT” file. > > That's obvious. Not to me :) > Why that breaks the RPM packaging procedure is not, as it uses the > tarballs from grass.osgeo.org too: > > https://src.fedoraproject.org/rpms/grass/blob/rawhide/f/grass.spec#_29 Yeah, using that one all goes fine. So, we may ignore that but may consider to fix https://github.com/OSGeo/grass/pull/3437 Best, Markus _______________________________________________ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
