Hi Colin, On Thu, Feb 22 2018 at 11:07:56 AM, Colin Watson <cjwat...@debian.org> wrote: > On Wed, Feb 21, 2018 at 11:48:56PM +0100, Bertrand Garrigues wrote: >> I'll add a check on the presence of pkg-config in m4/groff.m4 and update >> the doc. > > But the pkg-config macros themselves already do that ...
You are right, no need to add an extra check. >> It should be documented in INSTALL.extra rather then INSTALL.REPO as >> INSTALL.REPO described the specificities of buildin from git. > > This is exactly why I suggested that it should go in INSTALL.REPO, > because pkg-config is a dependency of ./bootstrap as well as of > ./configure. ./configure itself will issue a reasonable error if > pkg-config isn't installed, but ./bootstrap will only produce the > mysterious failure that Ralph noted. > > (I wouldn't object to it being documented in INSTALL.extra too.) I've updated INSTALL.REPO and INSTALL.extra. In fact pkg-config is only an optional dependency when building from a tarball (if pkg-config is not present 'configure' will not fail, it's just that it will be unable to look for 'uchardet'). Regards, Bertrand
