On Tue, Jan 16, 2007 at 03:04:37PM +0100, Simon Leinen wrote:
> Erik Romijn writes:
> > On Mon, Jan 15, 2007 at 10:46:36AM -0500, Larry J. Blunk wrote:
> [...]
> 
> > I am in favour of TABLE_DUMP_32BIT_AS. I don't see any real
> > advantage to moving to BGP4MP_ENTRY and do see significant extra
> > work to modify software.
> 
> One advantage of BGP4MP_ENTRY is that it includes the SAFI value.
> It is otherwise very similar to TABLE_DUMP, so I don't see how
> the extra work would be that much more significant than the work to
> implement the TABLE_DUMP_32BIT_AS that you propose.

One thing I'm missing here. Where is the peer's AS stored in a
BGP4MP_ENTRY? As a BGP attribute? Or is it not stored at all?
I don't see it being mentioned in the draft.

> > Also, it wouldn't hurt to add TABLE_DUMP_32BIT_AS, would it?
> 
> Well, not if you have it already, but if not it's more code...

We don't have it yet, but for both quagga and libbgpdump
TABLE_DUMP_32BIT_AS would be a trivial 30-second change.
All of the code is already there, we just need to disable the address
family mangling and use TABLE_DUMP_32BIT_AS instead.

Code for BGP4MP_ENTRY in quagga is partial, in libbgpdump non-existing.

regards,
-- 
Erik Romijn                 RIPE NCC jr. software engineer
http://www.ripe.net/        Information Services dept.

Attachment: pgpSMVy9GQeAU.pgp
Description: PGP signature

_______________________________________________
GROW mailing list
[email protected]
https://www1.ietf.org/mailman/listinfo/grow

Reply via email to