On Thursday 18 August 2005 23:19, Vincent Guffens wrote: > cool ! I will wait a little bit for your comments and those from Okuji > as there are a few changes I made that I'm not sure if they are very > clean, especially those in genmk.rb.
Good job, Vincent. > I used some "cat config.h" and > maybe there are some better ways. Possibly you can substitute a variable in Makefile.in and use the variable. > Should the Changelog entries be included in the patch or is it generated > with the cvs log and it should then be sent in the mail body ? ChangeLog must be handwritten. As long as it is written well, I don't care about how you send it. Using the Change Log mode in Emacs would help you a lot. It is still necessary to clean up the patch. Running make twice does not sound good. One easy way is to build a separate backtrace module outside the kernel, and load it as soon as possible, like the normal module. Also, I think it would be better to rename --enable-backtrace to --enable-debug, so that we can enable all debugging features by one option (when we get more debugging features, this could be useful). Okuji _______________________________________________ Grub-devel mailing list [email protected] http://lists.gnu.org/mailman/listinfo/grub-devel
