Sorry for the long delay, I've been very busy (and unfortunately I'll continue
to be :-().
On Fri, Feb 22, 2008 at 04:36:35PM +0100, Fabian Greffrath wrote:
> Well, the solution seems to be easier than I expected. Is the attached
> patch acceptable?
It looks good to me. Just a pair of minor details (simply for consistency with
code style in grub):
> + if (path == NULL)
> + {
> + if ( ! grub_util_check_block_device (device_name))
could you remove the space in "( !" ?
> + if (argument_is_device)
> + probe (NULL,argument);
> + else
> + probe (argument,NULL);
please add a space after the comma.
If you fix those, include a ChangeLog entry and noone else objects, I'll commit
it. Feel free to ping me with a direct mail if I stale for too long.
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
