Robert Millan schrieb:
Better do this like it's done in other scripts (check grub-install). Not sure
why, I guess it's more portable that way...
You mean
if [ "x$(FOO)" = "x" ] ...
?
For this one, I think it'd be much better to rework 10_hurd so that code is
shared, rather than duplicating the whole blurb.
Yes, we could source out the complete linux/hurd kernel-adding blurbs
into an external shell library that is shared with 10_* and 30_os-prober.
However, please don't forget these are two different things. 10_* look
on / and /boot, while os-prober looks on all *other* partitions.
Do you plan to do that later?
Not a concrete plan yet, However, we should first get thinks *working*
before we care about cosmetics, IMHO. ;)
Btw, what about *BSD? Does os-prober detect those as "chain" or ... ?
I asked myself the same question before. I seems like os-prober does
not support any of the BSD flavours, which sounds strange since it
even discovers Solaris on i386.
Should be a bug against os-prober.
Maybe it's better to echo something here, otherwise it gives the impression
OS FooBar was just detected and properly added.
Definitely. I'll add a short warning message.
Furthermore, I am going to modify the script to immediately 'exit 0'
if it turns out it misses the tools required to update the boot menu
(i.e. os-prober, linux-boot-prober, grub-probe (>= 20080228)). These
tests are spread all over the script at the moment.
Best Regards,
Fabian
PS: Shouldn't 30_os-prober be an upstream feature of os-prober?!
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
