On Sun, Jul 19, 2009 at 03:43:10AM +0800, Bean wrote: > On Sun, Jul 19, 2009 at 3:11 AM, Robert Millan<r...@aybabtu.com> wrote: > > On Sat, Jul 18, 2009 at 10:11:19PM +0800, Bean wrote: > >> } > >> > >> grub_raid_rescan (); > >> + grub_lvm_fini (); > >> + grub_lvm_init (); > > > > This is aside from this patch, but I don't see the purpose of this > > grub_raid_rescan() function. It's in raid.mod but only used by > > grub-fstest, so at least it should be #ifdef'ed out, but looking at > > what it does, it seems very ad-hoc. It basically amounts to the > > same you're doing with grub_lvm_fini() and grub_lvm_init(). Could > > you fix this while at it? > > This is required. As raid and lvm scan device in init function, but > grub-fstest uses loopback device, which hasn't been setup in > grub_init_all. This code rescan raid and lvm, otherwise there won't be > available.
Ok, then please could you ifdef it for GRUB_UTIL ? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all." _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
