On Thu, Jul 23, 2009 at 02:58:50AM +0800, Bean wrote:
> On Thu, Jul 23, 2009 at 1:33 AM, Robert Millan<r...@aybabtu.com> wrote:
> > On Sun, Jul 19, 2009 at 05:41:04PM +0800, Bean wrote:
> >> + if (is_raid)
> >> + printf ("raid mdraid");
> >> +
> >> + if (is_lvm)
> >> + printf ((is_raid) ? " lvm" : "lvm");
> >
> > Is there a better way to handle this? Perhaps we could make the list
> > newline separated instead of space separated and avoid the problem
> > altogether.
>
> Hi,
>
> Actually, if we allows an extra space at the end of line, it can be
> written like this:
>
> if (is_raid)
> printf ("raid mdraid ");
>
> if (is_lvm)
> printf ("lvm ");
>
> The space is not visible, and ignored by grub-install anyway.
Ok. I'd prefer a newline, but it can always be changed later on.
Your patch seems fine to me.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
