On Tue, Jul 28, 2009 at 11:15:09PM +0800, Bean wrote:
> - buf2 = grub_zalloc (size);
> + buf2 = grub_malloc (size);
> if (!buf2)
> return grub_errno;
>
> + grub_memset (buf, 0, size);
We just received 'buf' as parameter. Why do we have to zero it here?
> +static int
> +probe_raid_level (grub_disk_t disk)
> +{
> + if (disk->dev->id != GRUB_DISK_DEVICE_RAID_ID)
> + return -1;
> +
> + return ((struct grub_raid_array *) disk->data)->level;
> +}
Since this an ad-hoc function, could you put it in the same block that
needs it? If 'static' qualifier is present, it won't result in nested
function AFAICT.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel
