On Wed, Jun 05, 2019 at 12:11:00AM +0200, John Paul Adrian Glaubitz wrote:
> On 6/4/19 8:51 PM, Leif Lindholm wrote:
> > Add ia64 to the architectures excluding a declaration for
> > grub_arch_sync_dma_caches.
> >
> > IA64 does not include any of the source files that require the function,
> > but was overlooked for d8901e3ba115 ("cache: Fix compilation for ppc,
> > sparc and arm64").
> >
> > Add it to the list of excluding architectures in order to not get
> > missing symbol errors when running grub-mkimage.
>
> Ah, now I get what the actual problem is. I'll test that tomorrow on real
> hardware.
>
> > #ifndef GRUB_MACHINE_EMU
> > -#if defined (__aarch64__) || defined (__powerpc__) || defined (__sparc__)
> > +#if defined (__aarch64__) || defined (__powerpc__) || defined (__sparc__)
> > || \
> > + defined (__ia64__)
>
> Nitpick, but could you actually put the arch names in alphabetical order?
>
> It looks weird adding ia64 at the end when everything is already sorted.
Haha, you're worse than me - I love it :)
If you can confirm the end result actually works on hardware, I'm
happy to resubmit with macros sorted. (If not, I'm with Alex on
dropping the CI until it's actually testable.)
/
Leif
> Adrian
>
> --
> .''`. John Paul Adrian Glaubitz
> : :' : Debian Developer - glaub...@debian.org
> `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
> `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel
