Hi! On 6/5/19 12:33 AM, Leif Lindholm wrote: > On Wed, Jun 05, 2019 at 12:11:00AM +0200, John Paul Adrian Glaubitz wrote: >> On 6/4/19 8:51 PM, Leif Lindholm wrote: >>> #ifndef GRUB_MACHINE_EMU >>> -#if defined (__aarch64__) || defined (__powerpc__) || defined (__sparc__) >>> +#if defined (__aarch64__) || defined (__powerpc__) || defined (__sparc__) >>> || \ >>> + defined (__ia64__) >> >> Nitpick, but could you actually put the arch names in alphabetical order? >> >> It looks weird adding ia64 at the end when everything is already sorted. > > Haha, you're worse than me - I love it :)
Yes, I'm a bit of an OCD person when it comes to sending patches. > If you can confirm the end result actually works on hardware, I'm > happy to resubmit with macros sorted. (If not, I'm with Alex on > dropping the CI until it's actually testable.) So, I have build-tested the patch on ia64 now. GRUB still builds fine with the patch applied. So no regression this regard. And here are the tests with grub-mkimage. First, without the patch: glaubitz@titanium:/srv/tmp/grub$ ./grub-mkimage --config=/boot/grub/grub.cfg --prefix="" -d grub-core -O ia64-efi -o ia64.efi ./grub-mkimage: error: undefined symbol grub_arch_sync_dma_caches. glaubitz@titanium:/srv/tmp/grub$ And now with the patch: glaubitz@titanium:/srv/tmp/grub$ ./grub-mkimage --config=/boot/grub/grub.cfg --prefix="" -d grub-core -O ia64-efi -o ia64.efi glaubitz@titanium:/srv/tmp/grub$ So, I can confirm the patch does what was expected. Tested-by: John Paul Adrian Glaubitz <glaub...@physik.fu-berlin.de> Thanks, Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
