On Mon, Dec 16, 2019 at 02:05:00PM +0100, Daniel Kiper wrote: > On Mon, Dec 16, 2019 at 01:37:33PM +0100, Patrick Steinhardt wrote: > > On Mon, Dec 16, 2019 at 01:25:01PM +0100, Daniel Kiper wrote: > > > On Tue, Dec 10, 2019 at 10:26:21AM +0100, Patrick Steinhardt wrote: > > [snip] > > > > + /* Get the passphrase from the user. */ > > > > + if (disk->partition) > > > > + part = grub_partition_get_name (disk->partition); > > > > + grub_printf_ (N_("Enter passphrase for %s%s%s (%s): "), disk->name, > > > > + disk->partition ? "," : "", part ? : "", > > > > + crypt->uuid); > > > > > > Why do you use grub_printf() instead of grub_printf()? > > > > I guess you mean grub_printf_() instead of grub_printf(). The > > Err... Right... > > > answer to that is simple: I copied it from "luks.c", and I saw it > > being used in various other modules for output that is > > user-facing and should thus be translated. Is there are more > > modern alternative that should be used instead? If so then I'm > > happy to use it instead. > > I am not sure about this underscore at the end. And there is no good > explanation around grub_printf_() and grub_printf() why they are both > different. So, if you copied this from "luks.c" let's leave it as is > for time being. > > Anyway, if there are no objections I will push this patch series by the > end of this week. > > Thank you for doing the work! > > Daniel
Cool, great news. Thanks a lot for your reviews! When this is merged I plan to tackle Argon2 support to make this more useful in the future. I guess we need support for this in libgcrypt first, though, so it will probably take some more time. Patrick
signature.asc
Description: PGP signature
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel