On Fri, Dec 20, 2019 at 08:33:04PM +0100, Daniel Kiper wrote: > On Tue, Dec 10, 2019 at 10:26:15AM +0100, Patrick Steinhardt wrote: > > Hi, > > > > this is the 6th version of this patchset aiming to implement > > support for LUKS2 disk encryption. All changes relate to the JSON > > interface, only: > > Sadly your patchset brakes at least i386-pc and arm-coreboot builds. > Compiler spits: [snip]
Indeed, there's two issues on 32 bit platforms:
- Mismatch between 32/64 bit types due to misuse of
`grub_size_t` instead of `grub_uint64_t`. This is easily
fixed by using the correct type.
- Use 64-bit division when calculating the disk offset, which
isn't supported natively on 32 bit platforms. This is also
easily fixed by using `grub_divmod64`.
I'll send an updated patch series in a few minutes.
Patrick
signature.asc
Description: PGP signature
_______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel
