On Mon, Sep 22, 2025 at 11:32:46AM +0530, Srish Srinivasan wrote:
> During command registration, grub_register_command_prio
> returns a 0 when there is a failure in memory allocation.
> In such a situation, calls to grub_unregister_{command(),
> extcmd()} during command unregistration will result in
> dereferencing a NULL pointer.
>
> Perform explicit NULL check in both the unregister helpers to
> prevent undefined behaviour due to a NULL pointer dereference.
>
> Signed-off-by: Srish Srinivasan <[email protected]>
> Reviewed-by: Sudhakar Kuppusamy <[email protected]>
> Reviewed-by: Stefan Berger <[email protected]>

Patch LGTM to me but it does not seem to be posted earlier to the
grub-devel. So, I cannot accept Sudhakar's and Stefan's RBs until they
are confirmed here.

Though Reviewed-by: Daniel Kiper <[email protected]>...

Daniel

_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel

Reply via email to