On Mon, Sep 29, 2025 at 05:47:59PM +0530, Srish Srinivasan wrote:
> On 9/29/25 5:25 PM, Daniel Kiper wrote:
> > On Mon, Sep 22, 2025 at 11:32:46AM +0530, Srish Srinivasan wrote:
> > > During command registration, grub_register_command_prio
> > > returns a 0 when there is a failure in memory allocation.
> > > In such a situation, calls to grub_unregister_{command(),
> > > extcmd()} during command unregistration will result in
> > > dereferencing a NULL pointer.
> > >
> > > Perform explicit NULL check in both the unregister helpers to
> > > prevent undefined behaviour due to a NULL pointer dereference.
> > >
> > > Signed-off-by: Srish Srinivasan <[email protected]>
> > > Reviewed-by: Sudhakar Kuppusamy <[email protected]>
> > > Reviewed-by: Stefan Berger <[email protected]>
> > Patch LGTM to me but it does not seem to be posted earlier to the
> > grub-devel. So, I cannot accept Sudhakar's and Stefan's RBs until they
> > are confirmed here.
> >
> > Though Reviewed-by: Daniel Kiper <[email protected]>...
> >
> > Daniel
> Hi Daniel,
> thank you for the reviewed-by.
>
> And, here are the links to v2 for the same patch where I got reviews from
> Sudhakar and Stefan.
>
> Sudhakar's reviewed-by:
> https://lists.gnu.org/archive/html/grub-devel/2025-09/msg00087.html
> Stefan's reviewed-by:
> https://lists.gnu.org/archive/html/grub-devel/2025-09/msg00113.html
>
> And, here is the link to v1 for the same patch just for your reference.
>
> https://lists.gnu.org/archive/html/grub-devel/2025-09/msg00072.html
>
> Hope this helps.
Sorry, I missed both emails due to subject change. I will get Sudhakar's
and Stefan's RBs then.
Daniel
_______________________________________________
Grub-devel mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/grub-devel
