On Mon, 24 Jan 2005 21:04:20 +0900
Daichi Kawahata wrote:

> The following patch completes static strings in the i18n user
> interface, there are still remaining strings I hope it turns
> translatable.

Where the above mentioned is string which is displayed at "Info"
columns. It shouldn't be translatable tagged at stdout stderr
(g_message, g_warning) while I think it's better to be translatable
wherever user will have to see in the user interface at run-time.

As concerned as i18n, I think this is final touch.

Index: po/POTFILES.in
===================================================================
RCS file: /cvsroot/gtk-gnutella/gtk-gnutella-current/po/POTFILES.in,v
retrieving revision 1.9
diff -u -r1.9 POTFILES.in
--- po/POTFILES.in  24 Jan 2005 19:06:31 -0000  1.9
+++ po/POTFILES.in  30 Jan 2005 07:08:13 -0000
@@ -1,9 +1,11 @@
 src/core/downloads.c
 src/core/gnet_stats.c
 src/core/gwcache.c
+src/core/nodes.c
 src/core/settings.c
 src/core/shell.c
 src/core/uhc.c
+src/core/uploads.c
 src/if/gnet_property.c
 src/if/gui_property.c
 src/lib/iso3166.c
Index: src/core/downloads.c
===================================================================
RCS file: /cvsroot/gtk-gnutella/gtk-gnutella-current/src/core/downloads.c,v
retrieving revision 1.35
diff -u -r1.35 downloads.c
--- src/core/downloads.c    22 Jan 2005 03:50:35 -0000  1.35
+++ src/core/downloads.c    30 Jan 2005 07:08:23 -0000
@@ -2540,7 +2540,7 @@
 
    } else if (status == DL_CHUNK_BUSY) {
 
-       download_queue_delay(d, 10, "Waiting for a free chunk");
+       download_queue_delay(d, 10, _("Waiting for a free chunk"));
        return FALSE;
 
    } else if (status == DL_CHUNK_DONE) {
@@ -5627,7 +5627,7 @@
                /* Server has nothing for us yet, give it time */
                download_queue_delay(d,
                    MAX(delay, download_retry_refused_delay),
-                   "Partial file on server, waiting");
+                   _("Partial file on server, waiting"));
            }
 
            return;
@@ -6113,7 +6113,7 @@
        g_assert(d->flags & DL_F_SHRUNK_REPLY);
        download_queue_delay(d,
            MAX(delay, download_retry_busy_delay),
-           "Partial file on server, waiting");
+           _("Partial file on server, waiting"));
        return;
    }
 
Index: src/core/nodes.c
===================================================================
RCS file: /cvsroot/gtk-gnutella/gtk-gnutella-current/src/core/nodes.c,v
retrieving revision 1.71
diff -u -r1.71 nodes.c
--- src/core/nodes.c    12 Jan 2005 03:25:10 -0000  1.71
+++ src/core/nodes.c    30 Jan 2005 07:08:25 -0000
@@ -824,7 +824,7 @@
                }
            } else if (NODE_IS_CONNECTING(n)) {
                if (delta_time(now, n->last_update) > node_connecting_timeout) {
-                   node_remove(n, "Timeout");
+                   node_remove(n, _("Timeout"));
                     hcache_add(HCACHE_TIMEOUT, n->ip, 0, "timeout");
                }
            } else if (n->status == GTA_NODE_SHUTDOWN) {
@@ -832,7 +832,7 @@
                    gchar reason[1024];
 
                    g_strlcpy(reason, n->error_str, sizeof reason);
-                   node_remove(n, "Shutdown (%s)", reason);
+                   node_remove(n, _("Shutdown (%s)"), reason);
                }
            } else if (
                current_peermode == NODE_P_ULTRA &&
Index: src/core/uploads.c
===================================================================
RCS file: /cvsroot/gtk-gnutella/gtk-gnutella-current/src/core/uploads.c,v
retrieving revision 1.25
diff -u -r1.25 uploads.c
--- src/core/uploads.c  12 Jan 2005 04:14:51 -0000  1.25
+++ src/core/uploads.c  30 Jan 2005 07:08:25 -0000
@@ -368,7 +368,7 @@
        gnutella_upload_t *u = (gnutella_upload_t *) sl->data;
        if (UPLOAD_IS_CONNECTING(u)) {
            if (u->status == GTA_UL_PUSH_RECEIVED || u->status == GTA_UL_QUEUE)
-               upload_remove(u, "Connect back timeout");
+               upload_remove(u, _("Connect back timeout"));
            else
                upload_error_remove(u, NULL, 408, "Request timeout");
        } else if (UPLOAD_IS_SENDING(u))
Index: src/ui/gtk/gtk2/downloads.c
===================================================================
RCS file: 
/cvsroot/gtk-gnutella/gtk-gnutella-current/src/ui/gtk/gtk2/downloads.c,v
retrieving revision 1.26
diff -u -r1.26 downloads.c
--- src/ui/gtk/gtk2/downloads.c 15 Jan 2005 20:30:13 -0000  1.26
+++ src/ui/gtk/gtk2/downloads.c 30 Jan 2005 07:08:28 -0000
@@ -1352,7 +1352,7 @@
            if (guc_get_parq_dl_position(d) > 0) {
 
                rw += gm_snprintf(&tmpstr[rw], sizeof(tmpstr)-rw,
-                   " (slot %d",        /* ) */
+                   _(" (slot %d"),     /* ) */
                    guc_get_parq_dl_position(d));
 
                if (guc_get_parq_dl_queue_length(d) > 0) {
@@ -1362,7 +1362,7 @@
 
                if (guc_get_parq_dl_eta(d)  > 0) {
                    rw += gm_snprintf(&tmpstr[rw], sizeof(tmpstr)-rw,
-                       ", ETA: %s",
+                       _(", ETA: %s"),
                        short_time((guc_get_parq_dl_eta(d)
                            - elapsed)));
                }

Of course, there are more strings in src/core/*.c files. I don't
know, should I report all that.

Thank you.
-- 
Daichi


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
Gtk-gnutella-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/gtk-gnutella-devel

Reply via email to