Daichi Kawahata wrote: > Christian Biere wrote: > > if you've updated and compiled from CVS after March 29th, you've > > probably lost your search filters. > Thanks, for this fix, I've been keeping my backup since I had noticed > filter brokenness, but your instruction seems not to work and even > on newly created filter, it will be lost per session with the following > warnings (force new-lined) or the like,
I guess you applied the patch to the yet unfixed version - as public
CVS lags behind (thus the 24 hrs delay). If you did that, the IDs
will be damaged again as soon as searches.xml is written back to
disk.
The fix is very small though:
Index: src/ui/gtk/search_xml.c
===================================================================
RCS file: /cvsroot/gtk-gnutella/gtk-gnutella-current/src/ui/gtk/search_xml.c,v
retrieving revision 1.17
retrieving revision 1.18
diff -u -r1.17 -r1.18
@@ -308,7 +309,7 @@
* @return a static buffer holding the string representation
*/
static const gchar *
-target_to_string(gpointer target)
+target_to_string(filter_t *target)
{
gpointer value;
static gchar buf[128];
@@ -677,7 +679,7 @@
newxml = xml_new_empty_child(parent, NODE_BUILTIN);
for (i = 0; i < G_N_ELEMENTS(builtins); i++) {
xml_prop_set(newxml, builtins[i].tag,
- target_to_string(builtins[i].target));
+ target_to_string(builtins[i].target()));
}
}
If you apply this patch, you should have the same sources as
me and the ID fixup patch should work - as long as the filters
still exist in searches.xml.
--
Christian
pgpu1F9YvyBiE.pgp
Description: PGP signature
