Hi Mark,

Excellent!

On Tue 17 Jan 2012 14:27, Mark H Weaver <m...@netris.org> writes:

> This patch makes our gensyms universally-unique.  Comments welcome.

I think the lazy initialization needs to happen within the lock.  Also
it would be nice to factor out the initialization of the random seed
would be a nice helper to have in random.[ch].  You probably don't need
to have a flag to support /dev/random (rather than urandom), because
after all it's only seeding a PRNG (and not a cryptographically safe
one, at that).

Otherwise looks great to me!

Andy
-- 
http://wingolog.org/

Reply via email to