Andy Wingo <wi...@pobox.com> skribis: > On Wed 18 Jan 2012 22:41, l...@gnu.org (Ludovic Courtès) writes: > >> Could you stick to GNU-style change logs, describing the change (for >> example, “New function”), and not the rationale, function, etc.? >> >> (Andy might disagree with me, but don’t listen to him. ;-)) > > FWIW I have grown to agree with you over time, and your chiding, while > not always well-received in the moment, has made for better commit logs > :)
Heh. :-) Apologies if this came out as chiding, though. >>> + static const char base64[GENSYM_RADIX] = >>> + "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789$@"; >>> + static const char base4[4] = "_.-~"; >> >> Could we use Gnulib’s ‘base64’ module instead? > > FWIW (again) I thought the same initially, but Mark is incrementing a > base64 buffer instead of continually reencoding a value. It seems OK in > this instance. Oh, right, makes sense. Ludo’.
