civodul pushed a commit to tag 1.8
in repository guix.
commit 11aef17a774c923b7ec88ea1f4bb453452339a2a
Author: Eelco Dolstra <[email protected]>
Date: Wed Oct 29 15:49:03 2014 +0100
Remove comments claiming we use a private PID namespace
This is no longer the case since
524f89f1399724e596f61faba2c6861b1bb7b9c5.
---
src/libstore/build.cc | 9 +--------
1 files changed, 1 insertions(+), 8 deletions(-)
diff --git a/src/libstore/build.cc b/src/libstore/build.cc
index 3c9db5f..e8067ac 100644
--- a/src/libstore/build.cc
+++ b/src/libstore/build.cc
@@ -1926,12 +1926,6 @@ void DerivationGoal::initChild()
/* Set up private namespaces for the build:
- - The PID namespace causes the build to start as PID 1.
- Processes outside of the chroot are not visible to
- those on the inside, but processes inside the chroot
- are visible from the outside (though with different
- PIDs).
-
- The private mount namespace ensures that all the bind
mounts we do will only show up in this process and
its children, and will disappear automatically when
@@ -2032,8 +2026,7 @@ void DerivationGoal::initChild()
throw SysError(format("bind mount from ‘%1%’ to ‘%2%’
failed") % source % target);
}
- /* Bind a new instance of procfs on /proc to reflect our
- private PID namespace. */
+ /* Bind a new instance of procfs on /proc. */
createDirs(chrootRootDir + "/proc");
if (mount("none", (chrootRootDir + "/proc").c_str(), "proc", 0, 0)
== -1)
throw SysError("mounting /proc");
