On 10/14/2013 05:23 AM, Andreas Enge wrote:
On Sun, Oct 13, 2013 at 07:20:59PM -0400, David Thompson wrote:
How does it look?
It compiles well and looks good, congratulations! One point, though:
If you do
cd
/nix/store/f06apny3g77kjk0wxzhmgl4b3ya77f0b-libtheora-1.1.1/lib/pkgconfig/
grep Requires *.pc
you only see ogg, not vorbis.
So I think you can move libvorbis from propagated-inputs into regular inputs.
At a later point, you might wish to add libsdl as an input (I think you were
working on it already.)
Andreas
Thanks for the feedback. Here's an updated patch.
>From 8b6a37847c8375acabc4c477c773ae768cece29f Mon Sep 17 00:00:00 2001
From: David Thompson <[email protected]>
Date: Sun, 13 Oct 2013 19:17:27 -0400
Subject: [PATCH] Add libtheora package.
---
gnu/packages/oggvorbis.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/oggvorbis.scm b/gnu/packages/oggvorbis.scm
index 589828b..00dfc01 100644
--- a/gnu/packages/oggvorbis.scm
+++ b/gnu/packages/oggvorbis.scm
@@ -80,6 +80,29 @@ polyphonic) audio and music at fixed and variable bitrates from 16 to
"See COPYING in the distribution."))
(home-page "http://xiph.org/vorbis/";)))
+(define-public libtheora
+ (package
+ (name "libtheora")
+ (version "1.1.1")
+ (source (origin
+ (method url-fetch)
+ (uri (string-append "http://downloads.xiph.org/releases/theora/libtheora-";
+ version ".tar.xz"))
+ (sha256
+ (base32
+ "0q8wark9ribij57dciym5vdikg2464p8q2mgqvfb78ksjh4s8vgk"))))
+ (build-system gnu-build-system)
+ (inputs `(("libvorbis" ,libvorbis)))
+ (propagated-inputs `(("libogg" ,libogg)))
+ (synopsis "A library implementing the theora video format")
+ (description
+ "The libtheora library implements the ogg theora video format,
+a fully open, non-proprietary, patent-and-royalty-free, general-purpose
+compressed video format.")
+ (license (license:bsd-style "file://COPYING"
+ "See COPYING in the distribution."))
+ (home-page "http://xiph.org/theora/";)))
+
(define-public speex
(package
(name "speex")
--
1.8.4.rc3
