Alex Kost <alez...@gmail.com> skribis: > I noticed that "--no-grub" option has no effect. For example, > "guix system --no-grub reconfigure" installs GRUB anyway. > > Further investigation showed that there is a problem in parsing build > options. After that commit (847391f) we have the following code: > > (append (parse-options-from args) > (parse-options-from (environment-build-options))) > > in several places. But 'parse-options-from' returns default values for > unspecified options, e.g. if you didn't set GUIX_BUILD_OPTIONS, then > (parse-options-from '()) will return an alist of default options > (including ‘(install-grub? . #t)’).
Indeed, good catch. Commit 6e1a7d1 fixes it. > So build commands will just ignore such options as "--no-grub" or > "--no-substitutes" if a user didn't tweak GUIX_BUILD_OPTIONS. The problem was in fact specific to the option handler for --no-grub; the one for --no-substitutes (and all the others I checked) always conses, so there’s no problem. Thanks, Ludo’.