Alex Kost <alez...@gmail.com> skribis: > Suppose a user specifies "--no-substitutes" in his GUIX_BUILD_OPTIONS > and then he calls "guix system reconfigure". What would happen? > Substitutes _will be used_ anyway, because: > ‘(parse-options-from args)’ will contain ‘(substitutes? . #t)’ among > other things and it will shadow the false value for substitutes returned > by ‘(parse-options-from (environment-build-options))’. > > Now (after your patch) the same will happen with "--no-grub": > “export GUIX_BUILD_OPTIONS=--no-grub” will not be honored unless a user > explicitly specifies "--no-grub" option one more time in a "guix system" > command.
Oh, that’s right. AFAICS, commit cf6ce3e fixes it. It was a good opportunity to factorize all that and to add tests. Thanks! Ludo’.
