Thank you for the welcome Ludovic Courtès. I just have a couple of questions.
> 3. Added the file to gnu/local.mk. Is this file to be updated when a new source file is added? > 4. Added a ChangeLog-style commit log. Is there a specific reference/manual on the "ChangeLog-style" I could review? > 2. Added a ‘remove-fhs-file-names’ phase to remove hard-coded > references to /bin/cat and /usr/bin/clear. And is ‘remove-fhs-file-names’ a custom phase? If not, which source file contains the available phases? Thank you in advance, and sorry for all the noob questions. Ludovic Courtès writes: > Hello, and welcome! > > Matthew Jordan <[email protected]> skribis: > >> I'm relatively new to guix, spent the first couple >> days getting used to running it in my VM. Loving it so far. Since I'm >> not sure what to expect I decided to package a simple program that I >> find quite handy. Let me know if I should change anything. >> >> Also note that I followed "8.5 Submitting Patches" of the "GNU Guix >> Reference Manual" > > Great! There’s a couple of things that this section doesn’t clearly > mention, such as copyright notices—there’s room for improvement. ;-) > >> From 5b33ed530e472008bddf85a2f23b3fa9857b365e Mon Sep 17 00:00:00 2001 >> From: Matthew Jordan <[email protected]> >> Date: Wed, 11 May 2016 09:25:13 -0400 >> Subject: [PATCH] Added package entr. > > Pushed as 5d38aa0 with these minor changes: > > 1. Added a copyright notice for you (let me know if you think it’s > incorrect!). > > 2. Added a ‘remove-fhs-file-names’ phase to remove hard-coded > references to /bin/cat and /usr/bin/clear. > > 3. Added the file to gnu/local.mk. > > 4. Added a ChangeLog-style commit log. > > Thank you! > > Ludo’. Sincerely, -- Matthew Jordan Sent with my mu4e
