On Mon, May 23, 2016 at 06:22:09PM +0100, Jeremy Robst wrote: Welcome, and thanks for the patch!
Unfortunately, I can't seem to apply it to my source tree. Is anybody else able to do so? I can't figure *why* it doesn't apply. Jeremy, are you able to apply it with `patch -p1` or `git am`? > +(define-public hdf4 > + (package > + (name "hdf4") > + (version "4.2.11") > + (source + (origin + (method url-fetch) This is strange. It renders as expected once the patch is downloaded, but in Mutt, it looks like this. I wonder if this has to do with the patch not applying? > + (arguments '(#:tests? #f)) We prefer to add a comment explaining why test are disabled. If there are no tests, then the comment can be "No test suite." > + (license (license:x11-style > + > "https://www.hdfgroup.org/ftp/HDF/HDF_Current/src/unpacked/COPYING";)))) To me, this looks more like a variation on the BSD license than the x11 license. Perhaps non-copyleft is a more appropriate choice. Can you look at some of our packages using non-copyleft and report back? Can you look into these questions and send an updated patch?
