On Tue, May 24, 2016 at 08:55:02AM +0200, Danny Milosavljevic wrote:
> On Mon, 23 May 2016 00:28:26 -0400
> Leo Famulari <l...@famulari.name> wrote:
> 
> > The failing test (helper_expand) seems to fail when it can't find
> > `which`. 
> 
> The failing test is test/helper-expand.c and it tries to do this:
>
>     str = rofi_expand_path ( "~/" ); <----- oh oh
[...]
>     str = rofi_expand_path ( "~root/" );   <--- oh oh
[...]
>             str[i] = g_strdup ( g_get_home_dir () ); <----------- oh oh
[...]
>             struct passwd *p = getpwnam ( &( str[i][1] ) ); <---------- oh oh

> What should we do about it?

How about disabling that test only? You can comment it out of wherever
it's invoked, or make it return true immediately. I'm not sure if we
have a canonical method... I think it depends on the language and
implementation.

Reply via email to