Hello, On Wed, Aug 03, 2016 at 10:53:11AM +0200, Tomáš Čech wrote: > * gnu/packages/bash.scm(bash-completion): Update to 2.3, add autoreconf > phase, change origin to Github. > * gnu/packages/patches/bash-completion-directories.patch: Rework - same > purpose, different code.
just the quick standard comment: Please do the switch from alist-... to modify-phases in a separate first commit; it makes it easier to see the real diff of your real commit. The autoreconf phase is strange. Why is it suddenly needed? If there is no way around it, you should at least add a comment. Andreas
