Julien Lepiller <jul...@lepiller.eu> writes: > Hi, > > I attached a patch to add fbida, a frame-buffer based image and pdf > viewer. I created a new file, since I didn't find an existing one > where it could go. Let me know if you prefer it in an existing file.
Hi Julien! Your patch looks fine as far as linting and reproducibility goes. Some pointers for your patch: In my opinion, this can go in pdf.scm, as the mupdf package is there and it has similar functions to fbida. Also, when you add fbida to pdf.scm, don't forget to add a copyright notice for yourself!
Description: PGP signature